Upgrade Ruby to version 3.3.6 #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unoduetre
commented
Dec 19, 2024
| @@ -12,7 +12,7 @@ Gem::Specification.new do |spec| | |||
| spec.homepage = "https://github.com/alphagov/govuk_document_types" | |||
| spec.license = "MIT" | |||
|
|
|||
| spec.required_ruby_version = ">= 3.1" | |||
| spec.required_ruby_version = ">= 3.2" | |||
There was a problem hiding this comment.
I've increased the required ruby version for the apps using this gem to 3.2. I didn't make it 3.3, because some apps do not use 3.3 yet.
unoduetre
force-pushed
the
3095-upgrade-our-apps-to-use-ruby-336-l
branch
2 times, most recently
from
80efe34 to
764259f
Compare
Fixed |
unoduetre
force-pushed
the
3095-upgrade-our-apps-to-use-ruby-336-l
branch
from
764259f to
1274204
Compare
catalinailie
approved these changes
Dec 27, 2024
| @@ -1,3 +1,7 @@ | |||
| # Unreleased | |||
|
|
|||
| * Drop support for Ruby 3.1, keep supporting Ruby 3.2, use Ruby 3.3 as default https://github.com/alphagov/govuk_document_types/pull/120 | |||
There was a problem hiding this comment.
I think it would be better to have these changes in a separate commit.
* Drop support for Ruby 3.1
unoduetre
force-pushed
the
3095-upgrade-our-apps-to-use-ruby-336-l
branch
from
1274204 to
2796bef
Compare
catalinailie
approved these changes
Dec 27, 2024
unoduetre
added a commit
that referenced
this pull request
Dec 27, 2024
* Drop support for Ruby 3.1, keep supporting Ruby 3.2, use Ruby 3.3 as default #120
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Upgrade all our apps to use Ruby 3.3.6.
Why
We want to keep our software up-to-date. Ruby 3.3.6 was released in November 2024, so we should upgrade to use it.
Trello card