Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate font download issue #3772

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Conversation

jon-kirwan
Copy link
Contributor

@jon-kirwan jon-kirwan commented Dec 13, 2023

What

Fix duplicate font download issue.

Why

This prevents inclusion of @font-face declarations (from _layout-header.css) which are not needed since they are served from elsewhere e.g. Static or the Component Guide stylesheets.

See https://frontend.design-system.service.gov.uk/sass-api-reference/#govuk-include-default-font-face.

Visual Changes

None.

@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3772 December 13, 2023 15:42 Inactive
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-3772 December 13, 2023 15:46 Inactive
@jon-kirwan jon-kirwan merged commit f0c27c3 into main Dec 14, 2023
10 checks passed
@jon-kirwan jon-kirwan deleted the fix-duplicate-font-download-issue branch December 14, 2023 09:13
@andysellick andysellick mentioned this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants