Use capabilities rather than options to resolve deprecation #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since selenium-webdriver version 4.0.0.alpha6 the options keyword argument has been deprecated for capabilities. To cater for this we have switched our keyword to use that and bumped the minimum version of Capybara and Selenium Webdriver to be the minimum version that these arguments will be supported for (to avoid any conditionals as per Capybara [1] [1]: https://github.com/teamcapybara/capybara/blob/f7ab0b5cd5da86185816c2d5c30d58145fe654ed/lib/capybara/registrations/drivers.rb#L21-L23
kevindew
force-pushed
the
fix-selenium-deprecation
branch
from
221bed8 to
c4d4be8
Compare
ollietreend
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since selenium-webdriver version 4.0.0.alpha6 the options keyword
argument has been deprecated for capabilities.
To cater for this we have switched our keyword to use that and bumped
the minimum version of Capybara and Selenium Webdriver to be the minimum
version that these arguments will be supported for (to avoid any
conditionals as per Capybara 1
This resolves #42