This repository has been archived by the owner on Apr 30, 2021. It is now read-only.
check-vulnerabilities: Stop whitelisting some images that just need pulling down first #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ulling down first This is to work around trivy being unwilling to work with their seemingly broken responses, see aquasecurity/trivy#401 (comment) This begins vulnerability checking on the following containers: quay.io/bitnami/sealed-secrets-controller:v0.7.0 quay.io/calico/node:v3.8.1 quay.io/open-policy-agent/gatekeeper:v3.0.4-beta.1 quay.io/kiali/kiali:v1.9 This involves making the container privileged and running dockerd.
Krenair
force-pushed
the
check-vulns-quay-2
branch
from
d303650 to
9931bfc
Compare
blairboy362
approved these changes
May 6, 2020
chrisfarms
approved these changes
May 7, 2020
There was a problem hiding this comment.
Well that is unfortunate ... I don't see any big issue with using privileged here (other than complexity and potential flakeyness of running dockerd as a background job without supervision). There are still plenty of other docker-image containers using privileged to run dockerd. It does mean it's "one more thing" to sort out the day we want to make concourse privileged-free.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to work around trivy being unwilling to work with their seemingly
broken responses, see aquasecurity/trivy#401 (comment)
This begins vulnerability checking on the following containers:
quay.io/bitnami/sealed-secrets-controller:v0.7.0
quay.io/calico/node:v3.8.1
quay.io/open-policy-agent/gatekeeper:v3.0.4-beta.1
quay.io/kiali/kiali:v1.9
This involves making the container privileged and running dockerd. This sounds scary so someone should check all the implications of this.