Replace embed tags in body when expanding links

When expanding links, any embedded content within the body of the linked
item should also be expanded to include the full value.

app/presenters/queries/expanded_link_set.rb

@@ -61,7 +61,7 @@ def present_expanded_link(link_hash)
           end
 
           if hash[:details]
-            hash[:details] = Presenters::DetailsPresenter.new(hash[:details], nil, nil).details
+            hash[:details] = Presenters::DetailsPresenter.new(hash[:details], nil, content_embed_presenter(hash[:content_id], hash[:locale])).details
           end
         end
       end
@@ -77,6 +77,11 @@ def available_translations
       def translations
         available_translations.translations
       end
+
+      def content_embed_presenter(content_id, locale)
+        edition = Document.find_by(content_id:, locale:).live
+        Presenters::ContentEmbedPresenter.new(edition) if edition
+      end
     end
   end
 end

spec/presenters/queries/expanded_link_set_spec.rb

@@ -39,40 +39,85 @@
   describe "details" do
     let(:c) { create_link_set }
 
-    before do
-      create_edition(a, "/a", document_type: "person")
-      create_edition(
-        b,
-        "/b",
-        document_type: "ministerial_role",
-        details: {
-          body: [
-            {
-              content_type: "text/govspeak",
-              content: "Body",
-            },
-          ],
-        },
-      )
-      create_edition(c, "/c", document_type: "role_appointment")
+    context "without embedded content in the body" do
+      before do
+        create_edition(a, "/a", document_type: "person")
+        create_edition(
+          b,
+          "/b",
+          document_type: "ministerial_role",
+          details: {
+            body: [
+              {
+                content_type: "text/govspeak",
+                content: "Body",
+              },
+            ],
+          },
+        )
+        create_edition(c, "/c", document_type: "role_appointment")
+
+        create_link(c, a, "person")
+        create_link(c, b, "role")
+      end
 
-      create_link(c, a, "person")
-      create_link(c, b, "role")
+      it "recursively calls the details presenter and renders govspeak inside expanded links" do
+        b = expanded_links[:role_appointments].first
+        c = b[:links][:role].first
+        expect(c[:details][:body]).to match([
+          {
+            content_type: "text/govspeak",
+            content: "Body",
+          },
+          {
+            content_type: "text/html",
+            content: "<p>Body</p>\n",
+          },
+        ])
+      end
     end
 
-    it "recursively calls the details presenter and renders govspeak inside expanded links" do
-      b = expanded_links[:role_appointments].first
-      c = b[:links][:role].first
-      expect(c[:details][:body]).to match([
-        {
-          content_type: "text/govspeak",
-          content: "Body",
-        },
-        {
-          content_type: "text/html",
-          content: "<p>Body</p>\n",
-        },
-      ])
+    context "with embedded content in the body" do
+      let(:contact) do
+        create(:edition, state: "published", content_store: "live", document_type: "contact", title: "Some contact")
+      end
+
+      before do
+        create_edition(a, "/a", document_type: "person")
+        create_edition(
+          b,
+          "/b",
+          document_type: "ministerial_role",
+          details: {
+            body: [
+              {
+                content_type: "text/govspeak",
+                content: "{{embed:contact:#{contact.document.content_id}}}",
+              },
+            ],
+          },
+          links_hash: { embed: [contact.document.content_id] },
+        )
+        create_edition(c, "/c", document_type: "role_appointment")
+
+        create_link(c, a, "person")
+        create_link(c, b, "role")
+      end
+
+      it "recursively calls the details presenter and embeds content inside expanded links" do
+        b = expanded_links[:role_appointments].first
+        c = b[:links][:role].first
+        expect(c[:details][:body]).to match([
+          {
+            content_type: "text/govspeak",
+            content: "Some contact",
+          },
+          {
+            content_type: "text/html",
+            content: "<p>Some contact</p>\n",
+          },
+        ])
+      end
     end
   end
 end