Add multi-level link expansion for edition links #2605
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brucebolt
force-pushed
the
implement-edition-link-expansion
branch
from
a947c20 to
513a0db
Compare
brucebolt
changed the title
brucebolt
force-pushed
the
implement-edition-link-expansion
branch
from
513a0db to
f42a62a
Compare
| puts "from" | ||
| Link | ||
| .left_joins(edition: :document) | ||
| .left_joins(:link_set) |
There was a problem hiding this comment.
You shouldn't need to join link_set here. If you look at the way this works in root_links_by_link_type, the idea is to make separate queries - one for link set links, and one for edition links.
def root_links_by_link_type(content_id:, locale:, with_drafts: false)
direct = own_links(content_id)
reverse = linked_to(content_id, rules.reverse_links)
edition = edition_links(content_id, locale, with_drafts)
reverse.merge(direct).merge(edition)
end
I assume we'd want to take a similar approach in child_links_by_link_type.
|
Closing as there's no active work ongoing with this. Can always reopen, if we decide to continue with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.