Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content modelling/865 fields in embed codes #3117

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

Harriethw
Copy link
Contributor

@Harriethw Harriethw commented Feb 3, 2025

This fixes the breaking changes introduced in to the ContentBlockTools gem: alphagov/govuk_content_block_tools#17


⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.

Follow these steps if you are doing a Rails upgrade.

@Harriethw Harriethw force-pushed the content-modelling/865-fields-in-embed-codes branch 2 times, most recently from c460318 to c030a75 Compare February 4, 2025 14:00
@Harriethw Harriethw marked this pull request as ready for review February 4, 2025 14:01
@Harriethw Harriethw requested a review from pezholio February 4, 2025 14:01
@Harriethw Harriethw force-pushed the content-modelling/865-fields-in-embed-codes branch from c030a75 to 4270cfd Compare February 4, 2025 14:39
with the latest update to the ContentBlockTools
gem we are enabling field names to be passed in the
embed code. So e.g.

{{embed:content_block_postal_address:2593f06c-b7c8-4173-9a47-09d9bdd767ef/town_or_city}}

would return just the `town_or_city` field on a postal
address content block. Field names currently are
restricted to those within the `details` json blob on a
block.
@Harriethw Harriethw enabled auto-merge February 4, 2025 16:07
@Harriethw Harriethw force-pushed the content-modelling/865-fields-in-embed-codes branch from 4270cfd to cc042a7 Compare February 4, 2025 16:08
the `content_block_postal_address` type is a placeholder
prototype to test blocks with more than one field. So I have
created a new type here that can be easily delete/merged
with a broader content block type if more are created.
@Harriethw Harriethw force-pushed the content-modelling/865-fields-in-embed-codes branch from cc042a7 to e22568e Compare February 4, 2025 16:35
@Harriethw Harriethw merged commit 61eb70f into main Feb 4, 2025
11 checks passed
@Harriethw Harriethw deleted the content-modelling/865-fields-in-embed-codes branch February 4, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants