Re-add Sidekiq to application #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leenagupte
reviewed
Feb 6, 2025
There was a problem hiding this comment.
Does a redis setup need to be added to the rspec workflow config? See .github/workflows/rspec.yml in the PR that removed sidekiq.
We've also talked in another form about a slight tweak to the wording of one of the comments.
Otherwise it looks good.
I don't think so – we should be using Sidekiq's testing facilities rather than relying on a real Redis in test. If it turns out we do need it, it should be simple enough to add in when we actually do 🤞 |
|
Also adding a note that alphagov/govuk-helm-charts#2969 should be merged before this PR 💡 |
leenagupte
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was removed due to a misunderstanding around this app not using Sidekiq (we removed some old code in advance of rebuilding it, and the app thus temporarily did not use Sidekiq).