Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .ruby-version to 3.2.2 #2583

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Update .ruby-version to 3.2.2 #2583

merged 1 commit into from
Dec 11, 2023

Conversation

govuk-ci
Copy link
Contributor

@govuk-ci govuk-ci commented Dec 8, 2023

Upgrades Ruby to 3.2.2. See commits for more details.
This PR should be tested before merge, as per https://docs.publishing.service.gov.uk/manual/ruby.html#update-ruby-version-in-the-relevant-repos.

Trello card: https://trello.com/c/K1grjTiC/3373-upgrade-ruby-versions-to-322-2

@floehopper floehopper self-assigned this Dec 11, 2023
@floehopper
Copy link
Contributor

I see the following deprecation warning in the test log:

WARNING: MYSQL_OPT_RECONNECT is deprecated and will be removed in a future version.

However, this seems to have been there before the Ruby version bump.

Looking into it more closely, it seems as if the problem lies with the mysql2 gem which sets MYSQL_OPT_RECONNECT to false even if the reconnect option is not specified in database.yml. See this code. Given that others have already raised an issue, I'd assume this will be fixed at least by the time MySQL removes the option altogether. So I don't think any action is required by us for now.

@floehopper
Copy link
Contributor

I deployed this branch to integration and clicked around the app a bit. I didn't see any problems with the app's behaviour, I didn't see any spike in errors in the Graphana dashboard, and I didn't see any exceptions reported in Sentry. So I think this is good to merge.

@floehopper floehopper force-pushed the upgrade-ruby-312-to-322 branch from 87425c4 to 50d2c0c Compare December 11, 2023 10:41
@floehopper floehopper self-requested a review December 11, 2023 10:46
@floehopper floehopper merged commit a49ea04 into main Dec 11, 2023
14 checks passed
@floehopper floehopper deleted the upgrade-ruby-312-to-322 branch December 11, 2023 10:47
floehopper added a commit that referenced this pull request Dec 11, 2023
And update BUNDLED WITH in `Gemfile.lock` to the appropriate Bundler
version.

These were missed in #2583 and I think it means we haven't actually been
running the app on v3.2.2 after that PR was merged.
floehopper added a commit that referenced this pull request Dec 11, 2023
And update BUNDLED WITH in `Gemfile.lock` to the appropriate Bundler
version.

These were missed in #2583 and I think it means we haven't actually been
running the app on v3.2.2 after that PR was merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants