Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(783) Configute Pact tests provider for Signon #3458

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

pezholio
Copy link
Contributor

@pezholio pezholio commented Dec 19, 2024

Trello card: https://trello.com/c/ifMWZl9n/783-add-api-adapters-for-signon

This adds the Pact tests provider and the workflow, so we can run Pact tests via gds-api-adapters (PR here alphagov/gds-api-adapters#1316).

I've also added some lightweight documentation with details about the endpoint and how to authenticate.

@pezholio pezholio force-pushed the content-modelling/783-add-api-adapters-for-signon branch 7 times, most recently from f1402ed to ae84daa Compare December 20, 2024 11:05
This adds some new provider and consumer states for Pact, so we can
set up contract testing successfully
@pezholio pezholio force-pushed the content-modelling/783-add-api-adapters-for-signon branch from ae84daa to 9f427ff Compare December 20, 2024 11:08
@pezholio pezholio marked this pull request as ready for review December 20, 2024 11:09
@pezholio pezholio changed the title Content modelling/783 add api adapters for signon (783) Configute Pact tests provider for Signon Dec 20, 2024
This will allow us to verify the gds-api-adapter Pact tests
@pezholio pezholio force-pushed the content-modelling/783-add-api-adapters-for-signon branch from 9f427ff to 6585b67 Compare December 20, 2024 11:10
Once the Pacts have been published by gds-api-adapters, we’ll be able
to link to the request/response detail too.
@pezholio pezholio force-pushed the content-modelling/783-add-api-adapters-for-signon branch from 6585b67 to 4f9713a Compare December 20, 2024 11:13
Copy link
Contributor

@JonathanHallam JonathanHallam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks

@pezholio pezholio merged commit 68e08ac into main Dec 20, 2024
15 checks passed
@pezholio pezholio deleted the content-modelling/783-add-api-adapters-for-signon branch December 20, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants