Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure static to work with dartsass in govuk-docker #3253

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

AshGDS
Copy link
Contributor

@AshGDS AshGDS commented Feb 9, 2024

What

  • Adds code to support dartsass compilation in govuk-docker, based off of Enable automatic recompiling of stylesheets whitehall#8812
  • One thing to mention is docker didn't like the execution of bin/dev so I had to run chmod +x bin/dev on my machine. Not sure if this will be an issue for others?

Why

  • static has not been updating its SASS/CSS properly when govuk_publishing_components is updated. This is due to the migration to dartsass.

How to test

  • Checkout this branch
  • Change your govuk-docker/static/docker-compose.yml to use command: bin/dev instead of command: bin/rails s --restart (or just checkout this branch of govuk-docker: Use dartsass for static css compilation govuk-docker#721)
  • Change static to use your local govuk_publishing_components then make static / run static
  • When you change SASS in govuk_publishing_components, it should update instantly in static

@AshGDS AshGDS self-assigned this Feb 9, 2024
@AshGDS AshGDS force-pushed the govuk-docker-dartsass branch 2 times, most recently from efe62d8 to f78fa2f Compare February 9, 2024 11:57
@AshGDS AshGDS merged commit 711fcb9 into main Feb 9, 2024
12 checks passed
@AshGDS AshGDS deleted the govuk-docker-dartsass branch February 9, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants