Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Node.js LTS ‘Iron’ (v20) #60

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Use Node.js LTS ‘Iron’ (v20) #60

merged 2 commits into from
Jan 8, 2024

Conversation

colinrotherham
Copy link
Contributor

Updates the project from Node.js v18 to v20

This was after reading about Jest issues in the Stylelint v16 migration guide in their switch to ES modules

We should update Node.js now to avoid confusing errors later

Improved error messages

  • Node.js v18 segmentation faults when Node.js VM modules try to use dynamic import()
  • Node.js v20 throws an error clearly explaining what's happened
TypeError: A dynamic import callback was invoked without --experimental-vm-modules

We've had similar issues over on GOV.UK Frontend in alphagov/govuk-frontend#3851

@colinrotherham colinrotherham merged commit f2c75ae into main Jan 8, 2024
2 checks passed
@colinrotherham colinrotherham deleted the node-20 branch January 8, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants