Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support usernames in tokens #56

Closed
Olivia5k opened this issue Oct 21, 2018 · 7 comments
Closed

Support usernames in tokens #56

Olivia5k opened this issue Oct 21, 2018 · 7 comments
Assignees

Comments

@Olivia5k
Copy link
Contributor

I've been enjoying the custom to sign your TODO items with your username, e.g.;

TODO(thiderman): Fix the foobar and the bizbaz

Setting the magit-todos-require-colon setting to nil makes the code find tokens, but it seems that it cannot read the contents and just prints the tokens;
20181021 195738

That last one is the only one that doesn't have a username (I have a yas snippet that expands with my username, so I rarely forget it).

I understand that this is an edge case and not how most projects does it. However, if it is not too much of a bother to add support of these kinds of tokens, I'd be the happiest camper! This is a lovely project, but it simply doesn't work for almost anything I work on, both professionally and during my spare time.

Cheers! 🎉

@alphapapa alphapapa self-assigned this Oct 25, 2018
@alphapapa
Copy link
Owner

I think we can do this by changing the require-colon setting to a keyword-suffix setting, which could be nil to match items like those. I'll add this when I get a chance. Thanks for suggesting.

alphapapa added a commit that referenced this issue Nov 22, 2018
Fixes #56.  Thanks to Lowe Thiderman (@thiderman) for suggesting.
alphapapa added a commit that referenced this issue Nov 22, 2018
Fixes #56.  Thanks to Lowe Thiderman (@thiderman) for suggesting.
@alphapapa
Copy link
Owner

@thiderman I think that should do it, and the default should work for you. Please let me know if it does!

alphapapa added a commit that referenced this issue Nov 22, 2018
Fixes #56.  Thanks to Lowe Thiderman (@thiderman) for suggesting.
@Olivia5k
Copy link
Contributor Author

@alphapapa Works flawlessly! Thank you so much! 😍

@alphapapa
Copy link
Owner

Great! By the way, I'd like to show this feature in a screenshot, but I don't think I have any repos that have items like that. If you are interested, would you take a screenshot of a magit-status buffer showing items like those that I could add to the readme? It would need to be a PNG, and about the same size as the others, 747 pixels wide and around 650 pixels tall.

@Olivia5k
Copy link
Contributor Author

Absolutely!

20181124 193524

Is that good? 💃

@alphapapa
Copy link
Owner

Perfect, thank you very much!

@alphapapa
Copy link
Owner

alphapapa commented Nov 24, 2018

@thiderman I just added support for grouping/sorting by suffixes in f97afdc. So if you sort first by suffix, items will be grouped by username. Let me know what you think. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants