-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support usernames in tokens #56
Comments
I think we can do this by changing the require-colon setting to a keyword-suffix setting, which could be nil to match items like those. I'll add this when I get a chance. Thanks for suggesting. |
Fixes #56. Thanks to Lowe Thiderman (@thiderman) for suggesting.
Fixes #56. Thanks to Lowe Thiderman (@thiderman) for suggesting.
@thiderman I think that should do it, and the default should work for you. Please let me know if it does! |
Fixes #56. Thanks to Lowe Thiderman (@thiderman) for suggesting.
@alphapapa Works flawlessly! Thank you so much! 😍 |
Great! By the way, I'd like to show this feature in a screenshot, but I don't think I have any repos that have items like that. If you are interested, would you take a screenshot of a magit-status buffer showing items like those that I could add to the readme? It would need to be a PNG, and about the same size as the others, 747 pixels wide and around 650 pixels tall. |
Perfect, thank you very much! |
@thiderman I just added support for grouping/sorting by suffixes in f97afdc. So if you sort first by suffix, items will be grouped by username. Let me know what you think. :) |
I've been enjoying the custom to sign your TODO items with your username, e.g.;
Setting the
magit-todos-require-colon
setting tonil
makes the code find tokens, but it seems that it cannot read the contents and just prints the tokens;That last one is the only one that doesn't have a username (I have a
yas
snippet that expands with my username, so I rarely forget it).I understand that this is an edge case and not how most projects does it. However, if it is not too much of a bother to add support of these kinds of tokens, I'd be the happiest camper! This is a lovely project, but it simply doesn't work for almost anything I work on, both professionally and during my spare time.
Cheers! 🎉
The text was updated successfully, but these errors were encountered: