Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add named exports to build files #3644

Merged
merged 3 commits into from
Jan 21, 2024
Merged

Add named exports to build files #3644

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c0091b7
Add named exports to build files
ypconstante Jul 5, 2023
02b06aa
Merge branch 'main' into build-named-exports
calebporzio Jan 21, 2024
b4e0069
wip
calebporzio Jan 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/alpinejs/builds/module.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import Alpine from './../src/index'

export default Alpine

export { Alpine }
2 changes: 2 additions & 0 deletions packages/collapse/builds/module.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import collapse from '../src/index.js'

export default collapse

export { collapse }
2 changes: 2 additions & 0 deletions packages/csp/builds/module.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import Alpine from './../src/index'

export default Alpine

export { Alpine }
6 changes: 4 additions & 2 deletions packages/focus/builds/module.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import registerFocusPlugin from '../src/index.js'
import focus from '../src/index.js'

export default registerFocusPlugin
export default focus

export { focus }
3 changes: 2 additions & 1 deletion packages/history/builds/module.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@ import history from '../src/index.js'
import { track } from '../src/index.js'

export default history
export { track }

export { history, track }
2 changes: 2 additions & 0 deletions packages/intersect/builds/module.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import intersect from './../src/index.js'

export default intersect

export { intersect }
6 changes: 3 additions & 3 deletions packages/mask/builds/module.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import maskPlugin, { stripDown } from '../src/index.js'
import mask, { stripDown } from '../src/index.js'

export default maskPlugin
export default mask

export { stripDown }
export { mask, stripDown }
4 changes: 2 additions & 2 deletions packages/morph/builds/module.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import morphPlugin, { morph } from '../src/index.js'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these are two separate exports and should remain that way.

But now I see that this would mean this plugin diverges from the rest of the named plugin exports.

Hmmmm.... the "morphPlugin" variable is actually the plugin, and "morph" is the morphing function, not the full plugin.

So this change would cause a breakage for other people consuming { morph }

It's not documented so I'm not sure how much of a breaking change it would be, but it at least will probably break something internally? or with Livewire?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just found at least one usage of this. Jest tests are using this export.

Are this tests still used? They are not running on CI, and currently are failing.

import morph from '../src/index.js'

export default morphPlugin
export default morph

export { morph }
2 changes: 2 additions & 0 deletions packages/navigate/builds/module.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import navigate from '../src/index.js'

export default navigate

export { navigate }
2 changes: 2 additions & 0 deletions packages/persist/builds/module.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import persist from '../src/index.js'

export default persist

export { persist }
2 changes: 2 additions & 0 deletions packages/ui/builds/module.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import ui from '../src/index.js'

export default ui

export { ui }