Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(note-show-style-order) #640

Closed
wants to merge 1 commit into from
Closed

Conversation

HugoDF
Copy link
Contributor

@HugoDF HugoDF commented Jul 7, 2020

Closes #434

@SimoTod
Copy link
Collaborator

SimoTod commented Jul 7, 2020

I wish we could reconsider #236, to be fair (without the object support if Caleb is not sure). I think it's annoying that x-on:style overrides any values in pre existing style attributes.

@HugoDF
Copy link
Contributor Author

HugoDF commented Jul 7, 2020

I can revive it

I think the biggest issue was added bulk from that but if we just do string merging it should be ok.

@calebporzio
Copy link
Collaborator

Ok, I think Alpine should force x-show to override any :show bindings.

Is there a simple way to accomplish this without digging into the object syntax support (which I think we will likely end up adding after all)?

@HugoDF
Copy link
Contributor Author

HugoDF commented Jul 16, 2020

Well the only bit from that PR that we would need is the "style rule merging", or we can just order the operations so that style binding runs first and x-show second, always.

@HugoDF
Copy link
Contributor Author

HugoDF commented Jul 17, 2020

Closing since we're going to order the things

@HugoDF HugoDF closed this Jul 17, 2020
@HugoDF HugoDF deleted the docs-show-style branch July 17, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x-show gets overridden by :style
3 participants