latest from april 21 #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jay Summet <[email protected]>
Co-authored-by: Jay Summet <[email protected]>
Added the ability to enter a "debug" mode where an artificial intersection is created. This happens by: * Going to the About screen * Tapping on the Team icon 4 times * You can also return and tap 4 more times to toggle. When in this debug mode, faux intersection data is placed in the crossing arrays. This will either clear automatically during the 12-hour calculation, or can be cleared by the tester by returning to the About box and repeating the 4-tap.
Co-authored-by: Matteo Crippa <[email protected]>
* same intersect code as RC * adding a TODO to implement more scalable processing * add unit tests. Lots of minor fixes for edge cases * update to ExposureHistory to account for bins having exposure time in ms * update debug mode for mins in millis, as well as sprinkling in a few no-data days * bring debug mode in alignment on max exposure window constant * wip * change bin logic to handle DST change, update tests * fix disableDebug mode Co-authored-by: Ken Pugsley <>
Signed-off-by: Patrick Erichsen <[email protected]>
Co-authored-by: Tim Stirrat <[email protected]>
* Tweaks to better support small screens This fixes issues on phone screens as small as 320 pixels wide in various parts of the application. * Navigation bar text was too long (even in English) under the Choose Health Authority. When the screen width is < 400 pixels the font-size begins to scale. It also has enforced horizontal padding to prevent overlap with the back arrow -- text will now wrap instead of overlap. This change also helps with some translations which make it even longer. * The Exposure History legend was too long. I truncated the text "No exposure" to "No known" and the "Possible Exposure" to just "Possible" * The "Choose health authority" screen description text was being truncated. I changed the flex size of the list below it form 3 to 1 and tweaked the font size. This comfortably shows two entries even on a 320x533 screen in the emulator before that list requires scrolling, which will probably account for 90%+ of the use cases. * Slightly shrank the text in the News title for each webview and centered it so it looks better if it wraps. ## Technical Notes ## It seems like modifying Typography.js to scale might be a good idea, but I didn't want to go that big with this PR. ## Translation Notes ## The text for the two entries "Possible exposure" and "No exposure" have changed. It is important that those along with "No data" are kept very short, as they appear side-by-side. For example, the current Kreole translation for "No data" is "Pa gen okenn done" and gets cut off even with the short English labels for the other two. * Getting the "Steve" out Debugging message slipped in. * Remove test code left in accidentally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How to test