May 6, 2020 #29
Merged
May 6, 2020 #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New option to dev_setup.sh, --skip-ios, to skip configuration related to iOS. If Xcode is not installed, configuring without this option is not allowed. ### Testing Notes ### Please run ./dev-setup.sh on a Mac without Xcode. Result should be: Xcode must be installed to develop for iOS. Use option '--skip-ios' to setup development for Android only. (exit code 1) Add option --skip-ios and script should complete setting up development for Android only. Please run ./dev-setup on Mac _with_ Xcode and the script should run like before and setup for both Android and iOS development. ### Fixed Issues ### Setup script dev_setup.sh failed on macOS/Darwin if tools for iOS development were not installed.
* pass 1 - change tripleblindmarket to Path-Check * change to Path-Check/safeplaces-frontend where appropriate * stronger wording on the pull request template * license update * more wordsmith * undo license file change Co-authored-by: Ken Pugsley <>
* Consolidate on single theme aware button * Add secondary button style * Fix crash * Use the button everywhere! * Button disabled states * Fix onboarding1 * Fix bad merge * Convert share button to <Button> * Pass through style and other props * More style updates and reconfig * Button tweaks * More tweaks * Don't force opacity when not needed * Add tests * Update other snaps * Fix iOS * Add some spacing for iOS * Restore padding for icon buttons * update snaps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Linked issues:
Screenshots:
How to test: