latest from march 29 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The custom styles were taken from https://snazzymaps.com/style/127403/no-label-bright-colors which was linked to in the issue #243 Closes #243
…237) * Add News, Import, Export buttons * add new colors * add positive and sensitive buttons * change button color in the main menu * notification UI * remove callback for button
* 1. Added RN permissions to dependencies. 2. Added location permissions in AndroidManifest.xml * 1. Permissions now handled by react-native-permissions 2. If platform is iOS 12.x.x or earlier. Directly acquire 'Always Allow' permission 3. If platform is iOS 13.0 or later, redirect to app settings. Apps cannot directly ask for 'Always Allow' post iOS 13. * Added comments * Added yarn.lock and Podfile.lock to gitignore * No changes * Added lock files * Removed Podfile.lock Co-authored-by: Rich Paret <[email protected]> Co-authored-by: Abhishek Singh <[email protected]>
Co-authored-by: Harsh Vitra <[email protected]>
Co-authored-by: Harsh Vitra <[email protected]>
There were some react warnings being thrown due to the key prop not being set on some components. This sets the key prop on the components that are added in a loop
* Fixed Text on Notifications page * Fixed Font size of Export Co-authored-by: Harsh Vitra <[email protected]>
* Update Export screen to show more accurate log data This is a pretty update to how the Export screen works and how the log data is modified. The Export screen component was rewritten as a functional component in order to take advantage of hooks. The use for the hooks is to update the log data details when the Export component comes in to focus. The old version would only update the data once since the component would mount and never unmount leading to stale data. The new Export component will update the log details each time the view comes in to focus. The log details have now been broken up in to 3 sections: Total time the log covers, Number of points logged, and Time since last updated. The LocationService has been updated with a new class called LocationData. This take the old saveLocation method and makes it an instance method on the LocationData class. This also allows access to the location data that is in memory in order for the Export screen to show more accurate details. The LocationService has been updated to use this new class when saving the location data. * Revert change to the location time interval * Remove old references to some variable names * Fix export tests due to changes * Add LocationData tests * Remove old test file
…as well (#250) * Add News, Import, Export buttons * add new colors * add positive and sensitive buttons * change button color in the main menu * change marker icon and description * remove maps-clustering package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.