Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spaces double encoded #10

Closed
ludwiktrammer opened this issue Oct 21, 2015 · 1 comment
Closed

Spaces double encoded #10

ludwiktrammer opened this issue Oct 21, 2015 · 1 comment

Comments

@ludwiktrammer
Copy link
Contributor

When the spaces option is set to true the toString method changes spaces to "+" signs and then urlencodes the "+" sign again, making it a literal "+" instead of encoded space:

if ($spaces) str = str.replace(/ /g, "+");
return encodeURIComponent(str);

The first line changes spaces to +, the second line changes + to %2B.
@ludwiktrammer ludwiktrammer changed the title Spaces double encoded when spaces set to true Spaces double encoded Oct 21, 2015
ludwiktrammer added a commit to ludwiktrammer/jquery-plugin-query-object that referenced this issue Oct 22, 2015
@ludwiktrammer
Fix double encoding of spaces
9a984d7 
Fixes issue alrusdi#10
@ludwiktrammer ludwiktrammer mentioned this issue Oct 22, 2015
Merged
Abdelhady added a commit to Abdelhady/jquery-plugin-query-object that referenced this issue Oct 25, 2015
@Abdelhady
this change fixes alrusdi#10 by replacing the encoded space by pluse …
26963e4 
…after the actual encoding takes place, not before it
@Abdelhady Abdelhady mentioned this issue Oct 25, 2015
Closed
@alrusdi
Copy link
Owner

alrusdi commented Nov 13, 2015

Seems to be fixed

@alrusdi alrusdi closed this as completed Nov 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

To fix Spaces double encoded issue #10 Abdelhady/jquery-plugin-query-object
2 participants
@alrusdi @ludwiktrammer