-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sof-hda-dsp: Support systems without integrated graphics audio #15
Conversation
@juimonen and @perexg please review. You can test this on any system that supports SOF (and recent kernel) with following kernel option: options snd_sof_intel_hda_common codec_mask=0x1 ... this will disable HDMI HDA codec. On older kernel SOF probe still fails, but this is fixed in recent kernel. Or alternative a system like HP Omen17 that has no integrated graphics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ucm2/sof-hda-dsp/Hdmi.conf
Outdated
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
newline?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@plbossart oops, fixed
On systems where integrated graphics audio is not present or is disabled, the HDMI PCM nodes are disabled. Add rules to detect these systems by checking presence of HDMI jack controls with UCM2 rules. Signed-off-by: Kai Vehmanen <[email protected]>
a373ac9
to
0971495
Compare
And the support for the fourth HDMI output? I think that it was added to the driver, wasn't? |
@perexg wrote:
Yes, that needs to be added in a separate patch. |
Merged via 4722f5b . |
@perexg Btw, any plan for a new alsa-ucm release? It seems quite a few people are hitting issues without this patch in alsa-ucm (e.g. thesofproject/linux#1985 and thesofproject/linux#1917 at least, but in general any laptop with NVidia GPU). Without this, Pulseaudio keeps trying to open the non-existing i915 HDMI PCM devices. |
@kv2019i alsa-ucm-conf or alsa-lib? |
@plbossart wrote:
alsa-ucm-conf |
On systems where integrated graphics audio is not present
or is disabled, the HDMI PCM nodes are disabled. Add rules to
detect these systems by checking presence of HDMI jack controls
with UCM2 rules.
Signed-off-by: Kai Vehmanen [email protected]