[QInputNumber] upgrade with additions and formatting #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Esvalirion
commented
Mar 16, 2021
Esvalirion
commented
- Add prefix and suffix
- Formatting by locale
- Mode with group separators
ViZhe
requested changes
Mar 16, 2021
ViZhe
reviewed
Apr 1, 2021
ViZhe
reviewed
Apr 1, 2021
ViZhe
reviewed
Apr 1, 2021
ViZhe
reviewed
Apr 1, 2021
ViZhe
reviewed
Apr 1, 2021
ViZhe
reviewed
Apr 1, 2021
ViZhe
requested changes
Apr 5, 2021
ViZhe
requested changes
Apr 14, 2021
ViZhe
approved these changes
Apr 14, 2021
shamilfrontend
approved these changes
Apr 14, 2021
cheesytim
requested changes
Apr 22, 2021
Esvalirion
force-pushed
the
inputnumber-upgrade
branch
from
0211146 to
be205f0
Compare
ViZhe
requested changes
May 27, 2021
| ) | ||
| : 0; | ||
|
|
||
| if (number <= this.min) { |
There was a problem hiding this comment.
в пропасх стоит дефолт и тип намбер
| ) | ||
| : 0; | ||
|
|
||
| if (number >= this.max) { |
There was a problem hiding this comment.
в пропасх стоит дефолт и тип намбер
There was a problem hiding this comment.
ни то ни другое никак не влияет на то что этот пропс может иметь значение null
ViZhe
requested changes
May 28, 2021
| ) | ||
| : 0; | ||
|
|
||
| if (number >= this.max) { |
There was a problem hiding this comment.
ни то ни другое никак не влияет на то что этот пропс может иметь значение null
| ); | ||
| }, | ||
|
|
||
| getSelectionsAndInsertedValue() {}, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.