Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue with saving query to collection #2580

Merged
merged 1 commit into from
Jul 4, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,6 @@ export class WindowService {

updateWindowState$(windowId: string, data: ExportWindowState) {
return this.getWindowState(windowId).pipe(
take(1),
tap((window) => {
this.store.dispatch(
new layoutActions.SetWindowNameAction(windowId, {
Expand Down Expand Up @@ -508,7 +507,6 @@ export class WindowService {
// Validate that query is ACTUALLY in an existing collection
this.getWindowState(windowId)
.pipe(
take(1),
switchMap((data) => {
if (data?.layout.collectionId && data?.layout.windowIdInCollection) {
return from(
Expand Down Expand Up @@ -556,7 +554,7 @@ export class WindowService {
}

private getWindowState(windowId: string) {
return this.store.pipe(select(fromRoot.selectWindowState(windowId)));
return this.store.pipe(select(fromRoot.selectWindowState(windowId)), take(1));
}
private cleanupWindow(windowId: string) {
this.store.dispatch(new streamActions.StopStreamClientAction(windowId));
Expand Down
Loading