-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update docker push action #2771
Conversation
Reviewer's Guide by SourceryThis pull request updates the Docker push action to support multiple platforms and integrates it into the release workflow. It also adds documentation for self-hosting Altair GraphQL Cloud. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @imolorhe - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a comment explaining why the Docker daemon config needs to be updated.
- The new documentation file looks good, but consider adding a section on how to update the application.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
2. Building the Docker image from the source code | ||
|
||
#### Using the pre-built Docker image | ||
|
||
To install Altair GraphQL Cloud on your server using the pre-built Docker image, follow these steps: | ||
|
||
1. Create a new directory on your server and navigate to it: | ||
|
||
```bash | ||
mkdir altair-graphql-cloud |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Please provide more detailed instructions for building from source.
The current instructions are too vague. Please add the specific commands needed to build and run the Docker image, including navigating to the correct directory, building the image with the Dockerfile, and running the container with necessary environment variables. You can refer the user to the docker-compose.yml example for the required environment variables.
Suggested implementation:
#### Using the pre-built Docker image
To install Altair GraphQL Cloud on your server using the pre-built Docker image, follow these steps:
1. Create a new directory on your server and navigate to it:
```bash
mkdir altair-graphql-cloud
cd altair-graphql-cloud
Building the Docker image from the source code
To build the Docker image from the source code, follow these steps:
-
Clone the Altair GraphQL Cloud repository (if you haven't already):
git clone https://github.com/YourOrganization/altair-graphql-cloud.git cd altair-graphql-cloud
-
Navigate to the directory containing the Dockerfile. If the Dockerfile is in a subdirectory, change to that directory:
cd path/to/dockerfile-directory # change this to the actual directory if needed
-
Build the Docker image with the provided Dockerfile:
docker build -t altair-graphql-cloud .
-
Run the container with the necessary environment variables. Refer to the docker-compose.yml for a list of required environment variables:
docker run -d -p 80:80 -p 443:443 \ -e ENV_VAR1=value1 \ -e ENV_VAR2=value2 \ altair-graphql-cloud
Make sure to update the repository URL and the path to the Dockerfile directory if they differ in your setup. Also, adjust the environment variable placeholders and port mappings as needed based on your actual configuration.
Visit the preview URL for this PR (updated for commit 9fb3a0c): https://altair-gql--pr2771-imolorhe-update-dock-o1sz8pka.web.app (expires Thu, 27 Feb 2025 22:27:33 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 02d6323d75a99e532a38922862e269d63351a6cf |
Fixes
Checks
yarn test-build
Changes proposed in this pull request:
Summary by Sourcery
This pull request updates the Docker build and push process, adds a new workflow for pushing Docker images on releases, and provides documentation for self-hosting Altair GraphQL Cloud.
New Features:
Enhancements:
Build:
CI:
Documentation: