-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated docker push github action #2784
Conversation
Reviewer's Guide by SourceryThis pull request updates the Docker push GitHub Action to include a 'release' input, which determines whether to push the Docker image as the 'latest' release. It also introduces a 'docker-vars' job to generate the version based on the commit SHA and timestamp. Finally, it enables the 'release' option in the release.yml workflow. Sequence diagram for Docker push with releasesequenceDiagram
participant GitHub Actions
participant _push-docker.yml
participant Docker Hub
participant GitHub Container Registry
GitHub Actions->>_push-docker.yml: triggers workflow with push=true, release=true, version
_push-docker.yml->>_push-docker.yml: Determines version from inputs or commit SHA and timestamp
_push-docker.yml->>Docker Hub: Pushes image with tag 'latest'
_push-docker.yml->>Docker Hub: Pushes image with tag 'version'
_push-docker.yml->>GitHub Container Registry: Pushes image with tag 'latest'
_push-docker.yml->>GitHub Container Registry: Pushes image with tag 'version'
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @imolorhe - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding a job to verify the docker image was successfully pushed.
- It might be helpful to add a description of the 'release' input to explain its purpose.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Visit the preview URL for this PR (updated for commit 0cd6168): https://altair-gql--pr2784-imolorhe-updated-doc-ijotni5f.web.app (expires Fri, 14 Mar 2025 16:05:42 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 02d6323d75a99e532a38922862e269d63351a6cf |
0f98e68
to
225ad86
Compare
225ad86
to
0cd6168
Compare
Fixes
Checks
yarn test-build
Changes proposed in this pull request:
Summary by Sourcery
Update the push-docker GitHub Action to allow pushing Docker images as the latest release and to generate dynamic versions.
CI: