-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix foreground color that has the same color as the background #240
base: master
Are you sure you want to change the base?
Conversation
@altercation @TrevorBramble bump. we've been waiting for a solution to #220 for half a year now... |
That’s odd. It doesn’t seem to do that on my end. |
Yeah indeed, it seems to cause issues if you use vim (with the vim solarized dark colors) in iTerm2 (with my solarized fork). I’m not sure then if the problem is with the iTerm2 or the vim theme. @TrevorBramble any ideas? Also, if you need any help dealing with all the PR maybe I can help a bit... not much activity in the repo lately. |
Seems like my fix to the iTerm2 solarized theme causes some issues with vim so I blindly tweaked the vim theme. Seems to work.
@noxoc I did a little tweak to the vim theme and at first glance it seems to do the trick. I’m no expert though. https://github.com/hydrozen/solarized/commit/13d13ea3ee5060c90baa650d6db7c2bd01dac33d |
bumping this thread in hope that this issue would be fixed |
ditto - hydrozen's fork fixes both iterm2 and vim for me (using item2 dark and solarized.vim) |
@spicydonuts cool! glad someone is using this :) |
would be better if was merged. What's the stopper? |
I’m not sure, I’m not an expert in theme-making, but I feel like my forks are at the very least a step in the right direction in finding a solution. |
It can be used at least as workaround. @altercation @TrevorBramble guys, would be great if you merge it. Thanks :) |
Otherwise it is set to the light grey of the fixed Solarized and looks meh.
Force the background of SignColumn to none
I think we need to consider an official fork of this repo. The maintainer doesn't seem to care about fixing this issues. I don't blame him, this is a huge work. |
Anyone tried to increase iTerm2 's contrast ? Light gray color becomes visible after increasing contrast a little bit. |
Replaced the light black with a gray instead of the dark blue which I believe is the same color as the background. This should solve #220, but I'm not 100% sure that I am using the right color.
Here's a screenshot of yeoman now: