-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement long targets pipeline for consistent nhmmer
results
#13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fit in a `Pipeline`
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
==========================================
- Coverage 80.54% 80.28% -0.26%
==========================================
Files 3 3
Lines 4122 4296 +174
==========================================
+ Hits 3320 3449 +129
- Misses 802 847 +45
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on tests made after issue #12 I realised the implementation of
nhmmer
was inconsistent with the binary provided with HMMER3. This PR does the following:LongTargetsPipeline
to use when searching long nucleotide sequences, using a sliding window over the target instead of loading everything.nhmmer
to useLongTargetsPipeline
instead ofPipeline
Pipeline.search_hmm
also accept a queryProfile
orOptimizedProfile
Pipeline.search_seq
andPipeline.search_msa
to usePipeline.search_hmm
instead of duplicating code.