Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Release WorkFlow Git Action #42

Merged
merged 33 commits into from
Nov 4, 2023

Conversation

waterfallm
Copy link

@waterfallm waterfallm commented Sep 12, 2023

Use GitActions to produce Release and give confidence img file comes from source

Description

Simple Git Action takes 2 hrs to run for each build.
Manually triggered by click on Run Workflow in Git Actions TAB

image

How Has This Been Tested?

Has been run on my own fork(https://github.com/waterfallm/) and i'll run a few more tests before submitting proper.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s

@waterfallm waterfallm changed the title On Merge WorkFlow Git Action Create Release WorkFlow Git Action Sep 12, 2023
@aluminum-ice
Copy link
Owner

I like this PR. Would love to try it once it's ready.

@waterfallm
Copy link
Author

I like this PR. Would love to try it once it's ready.

Will sort ASAP.

@aluminum-ice
Copy link
Owner

There is a catch you need to consider. Since I compile nexmon in the build process, the image is huge with lots of empty space at the end. So, I run pishrink on it manually to shrink it. How will you recreate that in the gitaction?

@waterfallm
Copy link
Author

There is a catch you need to consider. Since I compile nexmon in the build process, the image is huge with lots of empty space at the end. So, I run pishrink on it manually to shrink it. How will you recreate that in the gitaction?

Yeap currently working on 2 issues..

  1. setting env.VERSION properly in action.
  2. size being > 2Gb looks like your suggestion will resolve that.

image

@waterfallm
Copy link
Author

@aluminum-ice

Latest update seems to have trimmed off enough i will test image produced once I've finished work today

image

@waterfallm
Copy link
Author

This test 1.7.9 version works straight from image produced using CreateRelease.

Only issue is git action file needs version manually updating at each run, no big issue for now.

image

@waterfallm
Copy link
Author

@waterfallm waterfallm marked this pull request as ready for review September 18, 2023 17:04
@aluminum-ice
Copy link
Owner

aluminum-ice commented Sep 19, 2023

pishrink will change the sha256 value. The action needs to run sha256sum to compute the right value for the shrunk image. Example:

sha256sum pwnagotchi-raspios-lite-1.7.9-shrink.img > pwnagotchi-raspios-lite-1.7.9-shrink.sha256

@waterfallm
Copy link
Author

pishrink will change the sha256 value. The action needs to run sha256sum to compute the right value for the shrunk image. Example:

sha256sum pwnagotchi-raspios-lite-1.7.9-shrink.img > pwnagotchi-raspios-lite-1.7.9-shrink.sha256

Command to update sha and label of release changed to version number

@aluminum-ice aluminum-ice merged commit 29611ff into aluminum-ice:master Nov 4, 2023
@aluminum-ice
Copy link
Owner

Thank you for your contribution. I just merged and I am running the action now to create release 1.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants