Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fixed and Improved #64

Merged
merged 3 commits into from
Nov 19, 2023
Merged

Conversation

shashankx86
Copy link

@shashankx86 shashankx86 commented Nov 5, 2023

Description

.sha256 of img is being compressed instead of actual img

Motivation and Context

Rigged release

Types of change

  • Bug fix (non-breaking change which fixes an issue)
    • Just changed .sha256 to .img in command to point actual img file

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s

.sha256 of img is being compressed instead of actual img
@shashankx86
Copy link
Author

shashankx86 commented Nov 6, 2023

Description

Improved Workflow

  • Instead of editing the YAML file each time to create a new release, you can now directly input the version you want to release.
  • Made the pishrink URL configurable, so if you ever need to use a different URL, you can simply change it in the input just before running the workflow.
  • Added the ability to input the 7z compress command, making it easy to modify the compression command as needed by changing it in the workflow input before running it.

Types of change

  • New feature (non-breaking change which adds functionality)

@shashankx86
Copy link
Author

shashankx86 commented Nov 6, 2023

@aluminum-ice
fixed, improved and tested, all works!

image

@shashankx86 shashankx86 changed the title CI: Fixed 7z compress img CI: Fixed and Improved Nov 6, 2023
@aluminum-ice
Copy link
Owner

Thank you these are great improvements.

@aluminum-ice aluminum-ice merged commit 5ff97c8 into aluminum-ice:master Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants