Fix history up issue reported by @jduck

alvarofe · May 14, 2017 · 2b4ef99 · 2b4ef99
1 parent 9c356a9
commit 2b4ef99
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/libr/cons/dietline.c b/libr/cons/dietline.c
@@ -221,19 +221,26 @@ static int r_line_readchar() {
 }
 
 R_API int r_line_hist_add(const char *line) {
+	if (!line || !*line) {
+		return false;
+	}
 	if (!I.history.data) {
 		inithist ();
 	}
 	/* ignore dup */
+	if (I.history.index != I.history.top) {
+		if (I.history.index + 1 != I.history.top) {
+			I.history.data[I.history.top++] = strdup (line);
+		}
+		I.history.index = I.history.top;
+		return true;
+	}
 	if (I.history.top > 0) {
 		const char *data = I.history.data[I.history.top - 1];
 		if (data && !strcmp (line, data)) {
 			return false;
 		}
 	}
-	if (!line || !*line) {
-		return false;
-	}
 	if (I.history.top == I.history.size) {
 		int i;
 		free (I.history.data[0]);