Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Image Support (now possible) #4

Closed
nicam opened this issue Jan 1, 2022 · 6 comments
Closed

Add Image Support (now possible) #4

nicam opened this issue Jan 1, 2022 · 6 comments
Assignees
@alvis
Labels
enhancement New feature or request

Comments

@nicam
Copy link

nicam commented Jan 1, 2022

Notion has now added image support :)

https://www.saurish.com/blog/notion-api-images
@alvis alvis self-assigned this Jan 2, 2022
@alvis alvis added the enhancement New feature or request label Jan 2, 2022
@alvis
Copy link
Owner

alvis commented Jan 2, 2022

Yes. Time to work on it! 👍🏼

@conradlin
Copy link

conradlin commented May 3, 2022 •
edited
Loading

How's the progress on this? Loving this plugin, working very well.

@mitchmalone
Copy link

Hey @alvis any update on this? Really excited to see this.

@tansongchen
Copy link

What is the status on image support @alvis ? If you haven't started maybe I can try to make a PR on that?

@alvis alvis closed this as completed in 79e51a7 Aug 31, 2022
alvis added a commit that referenced this issue Aug 31, 2022
@alvis
feat: support image block
0bb73c8 
fix #4
@alvis
Copy link
Owner

alvis commented Aug 31, 2022

Hi @mitchmalone @tansongchen! Sorry for the delay due to work.
But the good news is image support is now available on v1.2 & you can check out an example from the e2e folder 😃

@tansongchen
Copy link

Thanks for your super fast response! Upgraded to v1.2 and it worked like a charm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alvis alvis

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nicam @mitchmalone @alvis @conradlin @tansongchen