Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate c++std library #1578

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Conversation

ShootingKing-AM
Copy link
Member

@ShootingKing-AM ShootingKing-AM commented Apr 12, 2023

@ShootingKing-AM ShootingKing-AM changed the title No need to have shared c++ library when we have static c++ included No need to have shared c++ library Apr 12, 2023
@ShootingKing-AM ShootingKing-AM marked this pull request as draft April 12, 2023 21:06
@ShootingKing-AM ShootingKing-AM marked this pull request as ready for review April 12, 2023 21:12
@ShootingKing-AM ShootingKing-AM changed the title No need to have shared c++ library Remove duplicate c++std library Apr 12, 2023
@zmerp
Copy link
Member

zmerp commented Apr 12, 2023

The curious thing is that I added that line not too long ago to fix a crash on the smartphone/Monado version. I think we should control this using a cargo feature flag, and expose that from xtask too.

@ShootingKing-AM
Copy link
Member Author

The curious thing is that I added that line not too long ago to fix a crash on the smartphone/Monado version. I think we should control this using a cargo feature flag, and expose that from xtask too.

Can you link to the issue ? we can control it that way, but it really has c++static stdlib already in it, and it shouldn't ask for a new lib

@ShootingKing-AM
Copy link
Member Author

The curious thing is that I added that line not too long ago to fix a crash on the smartphone/Monado version. I think we should control this using a cargo feature flag, and expose that from xtask too.

Added shared stdlibc++ linking as a feature as suggested :)

Copy link
Member

@zmerp zmerp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this PR does not integrate with xtask to conditionally add the flag, it essentially disables it completely. I tested this on my Quest Pro and it works still. I think we can merge this and fix Monado compatibility another time.

@zmerp zmerp merged commit 33f53ce into alvr-org:master Apr 12, 2023
@ShootingKing-AM ShootingKing-AM deleted the patch-1 branch April 12, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to run library "libc++_shared.so" not found
2 participants