-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build issue on Android #23
Comments
@pvanliefland Which version of ReactNative are you on? |
I've run into the same issue running the following version(s):
|
I am using react native 0.27.2 @pvanliefland your solutions works no doubt :) |
@pvanliefland If i add these changes directly in node modules, the next time anyone install same library on my project he will not get any changes, what is the right way to add changes so next time the person who install this library will also get changes that we added manually. @rwillemsandroid if you can help that would be more appreciated as well :) |
@zfedoran I'm having the issue with React Native 0.35.0 |
Hello, I faced the same errors as @pvanliefland while compiling my react-native project but they were resolved by using the workaround he has provided. But now that I try to zoom by pinching the image, my app crashes. The error I get is:
My PhotoView component is:
Is the error because there is no constructor matching Event(viewId, eventType)? Is there a workaround for this error? |
@pvanliefland were you able to fix the issue(not be making changes in node module ofcourse)? I am also getting same errors while building my android app. Is it react-native version issue? |
I know this is a few months old now but This seems to be a react-native version issue. It is not really an issue with this library or RN. Basically upgrade to better versions. That PR was a response to this one from RN When i had this issue it was actually an issue with how i was retrieving react-native library. My library was defaulting to react-native:0.20.1 from here instead of using the local one in my node_modules folder. That version of RN does not have the change from above that was added I believe in 0.38. My problem was solved after i found this |
my project caused exactly same issue #23 And this solution fix it. So this promlem should be reconsidered my react native version is 0.43.3 and this pull request, which is closed without mergerd, solve my problem. I think this issue should be rediscussed now .. |
If anyone stumbles upon this issue, I boiled the issue to package.json -> "react-native":"...tz" My boilerplate (ignite) was using a direct .tz link for "react-native", rather than saying "v0.54.0" (or what ever the latest version is when you read this). This change along with a clean npm install allowed me to build successfully. |
i am having similar react native build problems:, Any help to fix this problem will be very helpful. :app:compileDebugJavaWithJavacE:\chewy\chewy-reactjs\android\app\src\main\java\com\users\MainActivity.java:3: error: package com.facebook.react does not exist |
me to |
Hello,
After letting Android Studio update various things (SDK, SDK tools etc...), my app does not build anymore.
The error I get is
Looks like the class constructor of the Event class extended by ImageEvent now expects two arguments.
As a workaround, I did this
Of course, I have no idea about what I'm doing there but at least my app compiles :)
The text was updated successfully, but these errors were encountered: