Fixing initialZoomScaleWithMinScale when image is larger than the screen #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alwx could you give me a suggestion? |
|
Example before the change, note that the image starts a little zoomed:
After change:
|
|
@alwx please, let me know if you need help to maintain this repository. |
|
Just a note that this fix has worked for my on iOS.
If it's at all possible to use this logic instead, it'd be wonderful. Thanks! |
|
Any reason why this hasn't been merged yet? |
|
work perfectly. |
|
I need this too :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, when the image is too large, it does not open in fit mode. #38
During the debug I realize that the value of
self.minimumZoomScaleis not consistent during the calculation. Storing this value in a variable solved the problem.