Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Trace log level in logrus #3

Closed
dgsb opened this issue Oct 20, 2018 · 1 comment
Closed

New Trace log level in logrus #3

dgsb opened this issue Oct 20, 2018 · 1 comment

Comments

@dgsb
Copy link

dgsb commented Oct 20, 2018

Hello, I'm just opening this issue to let you know, the next release of logrus (v1.2.0) will add a new trace level named Trace below Debug.
Here is the PR for reference sirupsen/logrus#844
You may want to take into account this new level.

@nblumhardt
Copy link
Contributor

nblumhardt commented Oct 21, 2018

Just checking out the code, it looks like no level mapping is done when sending events, but the Levels() function is explicit about handling a subset of values. Since Seq will happily accept both Verbose and Panic, it seems like the best response to this is to make logruseq transparent from a level perspective and just send through to Seq whatever logrus gives it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants