Merge pull request #261 from alyf-de/lan-817

landa/water_body_management/doctype/catch_log_entry/catch_log_entry.js

@@ -17,13 +17,15 @@ frappe.ui.form.on("Catch Log Entry", {
 		}
 	},
 	refresh: (frm) => {
-		if (frm.doc.docstatus == 0 && !frm.is_new()) {
+		if (!frm.is_new() && !frappe.workflow.is_read_only(frm.doc.doctype, frm.doc.name)) {
 			frm.add_custom_button(__("New Catch Log Entry"), () => {
 				frappe.new_doc(frm.doctype, {
 					organization: frm.doc.organization,
 					year: frm.doc.year,
 				});
 			});
+
+			frm.add_custom_button(__("Delete"), () => frm.savetrash());
 		}
 	},
 });

landa/water_body_management/doctype/catch_log_entry/catch_log_entry.py

@@ -4,6 +4,7 @@
 import frappe
 from frappe import _, get_roles
 from frappe.model.document import Document
+from frappe.model.workflow import get_workflow
 
 
 class CatchLogEntry(Document):
@@ -38,3 +39,22 @@ def validate(self):
 					),
 					title=_("Invalid Species"),
 				)
+
+	def before_save(self):
+		if self.is_new():
+			return
+
+		self.check_workflow_perms()
+
+	def on_trash(self):
+		self.check_workflow_perms()
+
+	def check_workflow_perms(self):
+		"""Raise a PermissionError if the user is not allowed to edit the document
+		in the current workflow state.
+		"""
+		workflow = get_workflow(self.doctype)
+		workflow_state = self.db_get(workflow.workflow_state_field)
+		frappe.only_for(
+			roles=[row.allow_edit for row in workflow.states if row.state == workflow_state],
+		)