feat: Firebase Notification Setup - FCM (LAN-801) #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Store firebase credentials
- Trigger function on version and deleted docuemtn insertion - Send FCM notification if right document - FirebaseNotification class wrapper around FCM requests
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
- Explicit returns and remove unused import
barredterra
reviewed
Jan 10, 2024
There was a problem hiding this comment.
Some thoughts:
- Maybe rename Water Body Management Settings to Firebase Settings
- Uploading and storing credentials as a file seems useful. But maybe we can store it outside the normal attachments (custom button "Upload File" -> show upload dialog -> own file handler -> store in site folder
bench/sites/landa/firebase/credentials.json) Project ID is contained in the credentials, does not need a separate settings field.never mind, not important
helps avoid invalid JSON data
|
First tests in staging environment look good now (at least no more errors from firebase) |
- Store Api file in sites folder. Delete file record created via file uploader (hard to overwrite) - Renamed settings to Firebase Settings
- Retries with exponential backoff
barredterra
reviewed
Jan 17, 2024
barredterra
reviewed
Jan 17, 2024
barredterra
reviewed
Jan 17, 2024
barredterra
previously approved these changes
Jan 18, 2024
in order to be able to update credentials
|
🎉 This PR is included in version 0.17.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ToDo: