Add ARK 4IN1 #27
Merged
Add ARK 4IN1 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please change the pr to draft, if it's not finished yet |
|
Can you explain your ideas behind nfault etc? Also please don't mix target prs and code prs. I have to ask you to separate those |
tridge
requested changes
Aug 23, 2024
AlexKlimaj
force-pushed
the
pr-ark-4in1
branch
7 times, most recently
from
1c3e31d to
4fb5465
Compare
AlexKlimaj
force-pushed
the
pr-ark-4in1
branch
from
c33fe31 to
2073c2f
Compare
|
Please separate target and code changes. The nSLEEP code should be an own PR, also always base from master and don't mix other PRs into this. |
|
The nSLEEP definition is required to set the initial pin state for the board definition.
Dropped the other commit.
It is based on main...
|
AlexKlimaj
force-pushed
the
pr-ark-4in1
branch
2 times, most recently
from
8dc8421 to
922207f
Compare
|
Any update on this PR? |
AlexKlimaj
force-pushed
the
pr-ark-4in1
branch
from
922207f to
505f51c
Compare
|
Rebased on main. |
AlexKlimaj
force-pushed
the
pr-ark-4in1
branch
from
505f51c to
998050c
Compare
AlkaMotors
approved these changes
Nov 6, 2024
tridge
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://arkelectron.com/product/ark-4in1-esc