fix: Fix ESM output of use-intl (#754)

amannn · Jan 3, 2024 · e73fb38 · e73fb38 · vercel · Jan 3, 2024
1 parent f8cdcf2
commit e73fb38
Show file tree

Hide file tree

Showing 6 changed files with 263 additions and 20 deletions.
diff --git a/packages/next-intl/package.json b/packages/next-intl/package.json
@@ -19,7 +19,9 @@
   "scripts": {
     "build": "rm -rf dist && rollup -c",
     "test": "TZ=Europe/Berlin vitest",
-    "lint": "eslint src test && tsc --noEmit",
+    "lint": "pnpm run lint:source && pnpm run lint:package",
+    "lint:source": "eslint src test && tsc --noEmit",
+    "lint:package": "publint && attw --pack",
     "prepublishOnly": "CI=true turbo test && turbo lint && turbo build && cp ../../README.md .",
     "postpublish": "git checkout . && rm ./README.md",
     "size": "size-limit"
@@ -87,6 +89,7 @@
     "react": "^16.8.0 || ^17.0.0 || ^18.0.0"
   },
   "devDependencies": {
+    "@arethetypeswrong/cli": "^0.13.5",
     "@edge-runtime/vm": "^3.1.3",
     "@size-limit/preset-big-lib": "^8.2.6",
     "@testing-library/react": "^13.0.0",
@@ -99,6 +102,7 @@
     "eslint-plugin-deprecation": "^1.4.1",
     "next": "^14.0.4",
     "path-to-regexp": "^6.2.1",
+    "publint": "^0.2.7",
     "react": "^18.2.0",
     "react-dom": "^18.2.0",
     "rollup": "^3.28.1",

diff --git a/packages/use-intl/package.json b/packages/use-intl/package.json
@@ -13,7 +13,9 @@
   "scripts": {
     "build": "rm -rf dist && rollup -c",
     "test": "TZ=Europe/Berlin vitest",
-    "lint": "eslint src test && tsc --noEmit",
+    "lint": "pnpm run lint:source && pnpm run lint:package",
+    "lint:source": "eslint src test && tsc --noEmit",
+    "lint:package": "publint && attw --pack",
     "prepublishOnly": "CI=true turbo test && turbo lint && turbo build",
     "size": "size-limit"
   },
@@ -68,6 +70,7 @@
     "react": "^16.8.0 || ^17.0.0 || ^18.0.0"
   },
   "devDependencies": {
+    "@arethetypeswrong/cli": "^0.13.5",
     "@size-limit/preset-big-lib": "^8.2.6",
     "@testing-library/react": "^13.0.0",
     "@types/node": "^20.1.2",
@@ -76,6 +79,7 @@
     "date-fns": "^2.16.1",
     "eslint": "^8.54.0",
     "eslint-config-molindo": "^7.0.0",
+    "publint": "^0.2.7",
     "react": "^18.2.0",
     "react-dom": "^18.2.0",
     "rollup": "^3.28.1",

diff --git a/packages/use-intl/rollup.config.js b/packages/use-intl/rollup.config.js
@@ -11,6 +11,10 @@ const input = {
 
 module.exports = [
   getBuildConfig({input, env: 'development'}),
-  getBuildConfig({input, env: 'esm'}),
+  getBuildConfig({
+    input,
+    env: 'esm',
+    output: {format: 'es'}
+  }),
   getBuildConfig({input, env: 'production'})
 ];
diff --git a/packages/use-intl/src/core/IntlConfig.tsx b/packages/use-intl/src/core/IntlConfig.tsx
@@ -1,7 +1,8 @@
+import type AbstractIntlMessages from './AbstractIntlMessages';
 import Formats from './Formats';
 import IntlError from './IntlError';
 import TimeZone from './TimeZone';
-import {AbstractIntlMessages, RichTranslationValues} from '.';
+import type {RichTranslationValues} from './TranslationValues';
 
 /**
  * Should be used for entry points that configure the library.