Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox complains about SameSite cookie #301

Closed
stefanprobst opened this issue May 22, 2023 · 2 comments · Fixed by #302
Closed

firefox complains about SameSite cookie #301

stefanprobst opened this issue May 22, 2023 · 2 comments · Fixed by #302
Labels
bug Something isn't working unconfirmed Needs triage.

Comments

@stefanprobst
Copy link
Contributor

Description

in firefox, i am seeing the following warning message in devtools console: "Cookie “NEXT_LOCALE” does not have a proper “SameSite” attribute value."

cookie

Mandatory reproduction URL (CodeSandbox or GitHub repository)

https://codesandbox.io/p/sandbox/next-intl-bug-template-forked-yow8ep

Reproduction description

Steps to reproduce:

  1. Open reproduction
  2. Open browser devtools
  3. See warning message

Expected behaviour

no warning message
@stefanprobst stefanprobst added bug Something isn't working unconfirmed Needs triage. labels May 22, 2023
@amannn amannn mentioned this issue May 22, 2023
Merged
@amannn
Copy link
Owner

amannn commented May 22, 2023

Thanks for the report! Should have a new patch release for this soon.

amannn added a commit that referenced this issue May 22, 2023
@amannn
fix: Set SameSite attribute for locale cookie to strict (#302)
0a6bce5 
Fixes #301
@bobmoff
Copy link

bobmoff commented Sep 11, 2024

How can I set it to 'none' if I want it work when someone embeds my site in an iframe ?

juanforlizzi pushed a commit to juanforlizzi/next-intl that referenced this issue Jan 16, 2025
@amannn
fix: Set SameSite attribute for locale cookie to strict (amannn#302)
faf2819 
Fixes amannn#301
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working unconfirmed Needs triage.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Set SameSite attribute for locale cookie to strict amannn/next-intl
3 participants
@bobmoff @amannn @stefanprobst