Update AmazingPrint::MongoMapper for frozen strings #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 15, 2020 09:40
Also, - Regenerate gemfiles - Ignore some Rubocop issues with generated gemfiles
HarlemSquirrel
changed the title
paddor
reviewed
Jun 15, 2020
paddor
reviewed
Jun 15, 2020
| @@ -90,7 +90,7 @@ def awesome_mongo_mapper_instance(object) | |||
| label = "#{colorize('embedded', :assoc)} #{label}" | |||
| end | |||
|
|
|||
| "#{label} " << awesome_hash(data) | |||
| [label, awesome_hash(data)].join(' ') | |||
There was a problem hiding this comment.
If the String should stay mutable, this should work too: +"#{label} #{awesome_hash(data)}". Up to you which one's more readable.
There was a problem hiding this comment.
I went back and forth on this one but based on #41 I thought using the same approach everywhere was nice.
|
@paddor I know the frozen string comments were removed from gemfiles as part of generating with appraisal. I thought this was fine since it's only for testing. Ignoring that and single quotes in Rubocop prevents needing to "correct" the gemfiles after running |
paddor
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure how many folks are using
mongo_mapperbut I noticed a fix was needed here and that specs were not running so I brought them back.