Rubocop updates #79
Merged
Rubocop updates #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
HarlemSquirrel
commented
Sep 12, 2021
•
HarlemSquirrel
commented
- Bump rubocop to latest version
- Add rubocop-rspec
- Enable new cops by default
- Generate new config file
- Auto-fix issues that are supported
- Fix some manual issues
HarlemSquirrel
force-pushed
the
rubocop-20210912
branch
from
42e4340 to
1565ab1
Compare
HarlemSquirrel
force-pushed
the
rubocop-20210912
branch
from
cd42be8 to
be431a3
Compare
paddor
reviewed
Sep 15, 2021
| @@ -7,8 +7,8 @@ class << self | |||
| # Class accessor to force colorized output (ex. forked subprocess where TERM | |||
| # might be dumb). | |||
| #--------------------------------------------------------------------------- | |||
| def force_colors!(value = true) | |||
| @force_colors = value | |||
| def force_colors!(colors: true) | |||
There was a problem hiding this comment.
Won't this API change break some code?
There was a problem hiding this comment.
Yeah I suppose you're right. Should we put this back?
There was a problem hiding this comment.
We also can do AmazingPrint.force_colors = false since it's an attribute accessor so we really don't need .force_colors! at all since it's really redundant.
paddor
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.