This repository has been archived by the owner on Mar 30, 2021. It is now read-only.
Fixing UnmodifiableBuffer equality bug #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UnmodifiableBuffer previously compared its own `records` object against itself rather than against the `records` object of the other buffer. This meant that `equals` would return true even if two buffers contained different records. Added unit tests to verify that UnmodifiableBuffer compares both its internal `IBuffer` and its list of records.
Maven currently autoscans for test files which match the pattern `*Test` but not `*Tests`, which means that running `mvn test` did not actually execute the tests in these files previously. Now they are executed by maven automatically.
|
Filed issue #81 to associate with this PR as well. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two commits, one contains a couple renames (see details below) so recommended to review them separately to see more meaningful diffs.
UnmodifiableBuffer previously compared its own
recordsobjectagainst itself rather than against the
recordsobject of theother buffer. This meant that
equalswould return true evenif two buffers contained different records.
Added unit tests to verify that UnmodifiableBuffer compares both
its internal
IBufferand its list of records.Additionally, several test files did not match maven's conventions (should be
*Testbut was*Tests) and so were not run when executingmvn test, so I renamed them.