[WIP] Replace cache.ListWatch with informers.NewSharedInformerFactory #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sky333999
reviewed
Jan 13, 2025
dims
force-pushed
the
replace-cache.ListWatch-with-informers.NewSharedInformerFactory
branch
from
86c1179 to
328f503
Compare
Signed-off-by: Davanum Srinivas <[email protected]>
dims
force-pushed
the
replace-cache.ListWatch-with-informers.NewSharedInformerFactory
branch
from
328f503 to
d99dc41
Compare
|
@sky333999 can you please enable CI workflows? |
|
looks decent. we can revive if needed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Link to tracking Issue:
Testing:
Documentation: