-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The main block should accept args array as an argument #154
The main block should accept args array as an argument #154
Conversation
Disclaimer: The installer script has to be probably rewritten now |
Oh never mind. It seems that it very well compiles. Perhaps due to the reason that we already use this variable as an array and it just seems to work: main(args) {
let os = get_os()
let arch = get_arch()
let user_only_install = includes(args, "--user")
// ... The same thing for uninstaller script |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Now instead of getting args this way where each arg is of type
Text
We can get them this way where the args variable is of type
[Text]