Prefer JavaScript UMD modules spec

It appears that Webpack is already handling the UMD import/export specification correctly when compiling the assets within Amber. In the amber.js websocket file, both UMD and common JS are present, and non-identical as both `class Channel` and `class Socket` are exported in the UMD format but only Socket is exported as CommonJS. A side-effect of this is that the `module.exports` object is transpiled into the bundle as Webpack has already defaulted to using UMD. This commit simply removes the CommonJS export definition.
amberframework · Jan 7, 2019 · ef0b73e · ef0b73e
1 parent c993acd
commit ef0b73e
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 7 deletions.
diff --git a/assets/js/amber.js b/assets/js/amber.js
@@ -223,11 +223,6 @@ export class Socket {
   }
 }
 
-module.exports = {
-  Socket: Socket
-}
-
-
 /**
  * Allows delete links to post for security and ease of use similar to Rails jquery_ujs
  */

diff --git a/assets/js/amber.min.js b/assets/js/amber.min.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "amber",
-  "version": "0.8.0",
+  "version": "0.8.1",
   "description": "Front-end configuration for Amber Framework",
   "private": true,
   "author": "Amber",
-Original file line number
+Diff line change
@@ Expand Up / @@ -223,11 +223,6 @@ export class Socket { @@
       }
     }
-    module.exports = {
-      Socket: Socket
-    }
     /**
      * Allows delete links to post for security and ease of use similar to Rails jquery_ujs
      */
@@ Expand Down @@