Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add method override field #1015

Merged
merged 4 commits into from
Dec 31, 2018
Merged

add method override field #1015

merged 4 commits into from
Dec 31, 2018

Conversation

drujensen
Copy link
Member

@drujensen drujensen commented Dec 30, 2018

Description of the Change

Auth is missing method override for editing profile.

This also fixes a bug in the ecr template that was missing the end ` tag

Alternate Designs

none

Benefits

fixes #1008

Possible Drawbacks

none

Copy link
Member

@elorest elorest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@drujensen drujensen merged commit 0165fec into master Dec 31, 2018
@drujensen drujensen deleted the dj/1008-fix-patch-ecr-template branch May 19, 2019 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Amber auth edit user don't work w/ method patch in form
2 participants