Resolved from failing tests from merged PRs in v1.4.0 #1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… broken up, hopefully this makes finding failing tests easier
…it's not included in the Accept header
- Defaults to _not_ listing directory contents - Adjusted some of the tests to reflect behavior from the std lib when a directory is requested but does not have the trailing /
…required to maintain Granite which is going to require it's own release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON responses now include the "charset=utf-8" which is valid but needed some tests updated
Static File serving was reproducing what the std lib was already doing, but with 1 convenience: requesting a directory without a trailing slash did not result in a redirect before serving a
404or200. That behavior no longer happens. So requesting a directory without the trailing slash will result in a redirect to the correct path before the final response is returned.Disabled the granite integration tests. There's some additional work that needs to be done to fix the failing postgres tests in CI before I cut a release that would resolve those tests. (Trying not to replicate my v1.4.0 experience here :) )