Refactor routing & pipeline dsl #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliasjpr
reviewed
Apr 23, 2017
| @@ -6,7 +6,7 @@ module Amber | |||
| describe "#call" do | |||
| it "raises exception when route not found" do | |||
| router = Router.instance | |||
| request = HTTP::Request.new("GET", "/hello/world") | |||
| request = HTTP::Request.new("GET", "/bad/route") | |||
eliasjpr
reviewed
Apr 23, 2017
src/amber/pipe/pipeline.cr
Outdated
| with PipelineDSL.new(self) yield | ||
| end | ||
|
|
||
| record PipelineDSL, pipeline : Pipeline do |
There was a problem hiding this comment.
I would like to learn more about Records this is very nice and clean. I see what you meant about using singletons
eliasjpr
reviewed
Apr 23, 2017
src/amber/pipe/router.cr
Outdated
| @@ -61,6 +61,27 @@ module Amber | |||
| trail = build_node(:HEAD, route.resource) | |||
| @routes.add(trail, route) | |||
| end | |||
|
|
|||
| record RouterDSL, router : Router do | |||
There was a problem hiding this comment.
Great cleanup! 🎉 I wanted to do something similar but didn't knew how to use macros
|
Maybe we should consider moving all the DSLs into Amber::Support::DSL module? to keep it organize? |
|
Why not, what is Amber::Support exactly for you? |
fridgerator
approved these changes
Apr 23, 2017
|
Amber::Support should host all of our custom stuff specific to the framework: DSL, Extensions, Modules etc |
This starts decoupling singletons from everywhere.
bew
force-pushed
the
refactor-routing-pipeline-dsl
branch
from
bcef853 to
e833a8b
Compare
eliasjpr
pushed a commit
that referenced
this pull request
Apr 26, 2017
* Move Router & Pipeline DSLs under Amber::Support::DSL module * Make the DSLs tied to a particular Router/Pipeline instance * Fix router spec
Closed
elorest
pushed a commit
that referenced
this pull request
Aug 26, 2017
marksiemers
pushed a commit
to marksiemers/amber
that referenced
this pull request
Oct 28, 2017
* Move Router & Pipeline DSLs under Amber::Support::DSL module * Make the DSLs tied to a particular Router/Pipeline instance * Fix router spec
elorest
pushed a commit
that referenced
this pull request
Nov 17, 2017
* Move Router & Pipeline DSLs under Amber::Support::DSL module * Make the DSLs tied to a particular Router/Pipeline instance * Fix router spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR moves the pipeline and routes DSLs inside Amber module, in the revelant classes.
DSLstands for Domain Specific Language. Here we have 2 distinct DSLs:plug)get,post, ...)Why Should This Be In Core?
Before theses changes, the 2 DSLs where exposed in the top level and where only macros, which could potentially break every program that includes them (see crystal-lang/crystal#236).
Benefits
pluginpipelinefor example).