Add options routes for routes with CORS pipeline in it #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliasjpr
approved these changes
Mar 9, 2018
NeverHappened
force-pushed
the
options_for_cors
branch
from
57db5d6 to
8f0d59b
Compare
|
Fixes #240 |
|
Closing this PR in favor of #700 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Add the options routes for routes with CORS pipe
Alternate Designs
Thought about other ways for doing this, but they were worse or impossible.
Maybe missed something.
Possible Drawbacks
I don't like that I added dependency between router and pipeline handlers. Couldn't thought of any other way.
Also the function that I call is in the server.cr call, the main point of app, kinda becomes polluted with unnecessary details.