Add missing make #680
Merged
Add missing make #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robacarp
approved these changes
Mar 7, 2018
eliasjpr
approved these changes
Mar 7, 2018
eliasjpr
pushed a commit
that referenced
this pull request
Mar 7, 2018
eliasjpr
pushed a commit
that referenced
this pull request
Mar 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Add make to avoid building amber using elevated permissions
Alternate Designs
No
Benefits
Avoid to create dirs and files with elevated permissions on build folder,
This will ask for permission just when amber is going to be installed
Possible Drawbacks
No